Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=561482 Mamoru Tasaka <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #3 from Mamoru Tasaka <[email protected]> 2010-02-19 10:53:07 EST --- (In reply to comment #2) > > * %check > > - As this tarball contains test/ directory, it is preferable that > > you add %check section and execute some test program there > > (if possible, I am not familiar with java) > > Couldn't find the 'test' build target (ant test doesn't work), so leaving be > for now unless this is a huge thing. - Well, then "BuildRequires(check): ant-junit" is not needed for now? - Now rpmlint warns about: --------------------------------------------------------------------- joni.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/joni-1.1.3/test/org/joni/test/TestC.java joni.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/joni-1.1.3/test/org/joni/test/TestU.java joni.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/joni-1.1.3/test/org/joni/test/TestA.java --------------------------------------------------------------------- Please fix these rpmlint messages by dos2unix or $ sed -i -e 's|\r||' TestC.java Please fix these when importing this package into Fedora CVS. --------------------------------------------------------------------- This pacakge (joni) is APPROVED by mtasaka --------------------------------------------------------------------- -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
