Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=530747 Paul Howarth <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #3 from Paul Howarth <[email protected]> 2010-02-22 07:01:39 EST --- (In reply to comment #2) > (In reply to comment #1) > > - Add optflags to CFLAGS > make %{?_smp_mflags} CFLAGS="-c -pedantic %{optflags} -DLINUX" > You add compile flags and even do not comment for what. It is not permitted in > Fedora: https://fedoraproject.org/wiki/Packaging:Guidelines#Compiler_flags At least %{optflags} should be used, as mentioned in the packaging guidelines URL you just cited. This includes things like -Wp,-D_FORTIFY_SOURCE=2 and -fstack-protector, which provide additional sanity checking of source code and protection from some buffer overflow issues. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
