Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=544016 James Findley <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #4 from James Findley <[email protected]> 2010-02-22 12:43:44 EST --- Ok, rpmlint is throwing up this: W: mixed-use-of-spaces-and-tabs (spaces: line 7, tab: line 16) So that needs to be fixed. > %define ... You should use %global rather than %define. http://fedoraproject.org/wiki/Packaging/Guidelines#.25global_preferred_over_.25define I'm also not sure they are strictly needed, as they make it harder to read. >Provides: policyd = %{version}, %{codename} = %{version} >Obsoletes: policyd < 2 Why are those there? as far as I can see, there is no policyd rpm in the repos, so the obsoletes isn't needed, and what problem is the Provides: meant to solve? > %preun You should probably stop the service before the chkconfig --del here. >%dir %{configdir} This is specified in two places. Perhaps a -common package? >%attr(0640,root,apache) should be %attr(640,root,apache) >%{logrotateconfdir}/%{name} >%{crondir}/%{name} These need the %config macro applied Other than that, it looks pretty good to me. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
