Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=567678 Christoph Wickert <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #3 from Christoph Wickert <[email protected]> 2010-02-23 20:33:13 EST --- (In reply to comment #0) > Camera Monitor is released under the terms of the GNU General Public License > Remove this sentence from the description, it's already in the License tag. The license of the package is GPLv2+. The + means GPLv2 "or any later version" (in contrast to "version 2 only" = GPLv2). You need look at the headers of the python files in order to distinguish this because COPYING wont tell. BuildRequires: python should be python-devel, see http://fedoraproject.org/wiki/Packaging:Python#BuildRequires There are a lot of missing Requires: Usually rpmbuild will generate them automatically, but not for python. You should look at the "import" statements of the python files, I guess you will need at least pygtk2 and notify-python. Remove the macro for %{!?python_sitearch, it's not needed for a noarch package Move the python_sitelib to the top of the spec. GConf schemas are no config files, remove %config(noreplace) and ignore the warning that rpmlint will return. GConf schemas must be (un)installed properly, see https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#GConf %configure --prefix=%{_prefix} --libdir=%{_libdir} can be substituted with a simple %configure the rest is added automatically, use 'rpm --eval %configure' to check what the macro does. Use the %doc macro to install the doc. Simply use %doc AUTHORS ChangeLog COPYING NEWS README in the %files section, rpmbuild will install the docs and include them in the package. Your package owns all the files in %{python_sitelib}/cameramonitor/, but not the dir itself, thus it will be left behind after uninstall. Instead of listing all the files, you could simply use %{python_sitelib}/cameramonitor/ If you want to make sure to only include python files, you could use %dir %{python_sitelib}/cameramonitor/ %{python_sitelib}/cameramonitor/*.py* Same goes for %{_datadir}/cameramonitor/, it's unowned too. The *.desktop files need to be installed or validated, see https://fedoraproject.org/wiki/Packaging/Guidelines#desktop-file-install_usage Typo in the spec: coppies -> copies -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
