Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=568052 Terje Røsten <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|[email protected] |[email protected] Flag| |fedora-review? --- Comment #5 from Terje Røsten <[email protected]> 2010-02-25 10:22:03 EST --- ok rpmlint ok naming ok spec ok license: GPLv3+ ok lang ok sha1sum on src 9313971e8b3ca30935727cd2f23a073654d7c4b4 Normaliz2.2Linux64.zip 9313971e8b3ca30935727cd2f23a073654d7c4b4 Normaliz2.2Linux64.zip.1 ok koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=2013794 ok dirs ok perms Some small issues fixed and this will get approved: - in %install swap the two first lines: pushd source rm -rf %{buildroot} -> rm -rf %{buildroot} pushd source - change last paragraph in desc to e.g. Documentation and examples can be found in %{_docdir}/%{name}-%{version}, in particular you may find Normaliz%{version}Documentation.pdf useful. An example configuration file normaliz.cfg is also included. - consider to use dos2unix -k ... or other means to preserve timestamps on *.in and *.out files. - I don't like the spaces in Computing the integral closure of an affine semigroup.pdf, but that's might be my problem. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
