Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=540761 Matthias Clasen <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review+ --- Comment #29 from Matthias Clasen <[email protected]> 2010-03-01 09:34:56 EST --- > not sure what to do about: Just remove the man pages from the explicit file list. Since you added --with-man to the %find_lang invocation, the .lang file already has those (with annotations now): %lang(en) /usr/share/man/en_GB/man1/deja-dup.1* %lang(ps) /usr/share/man/ps/man1/deja-dup.1* %lang(sv) /usr/share/man/sv/man1/deja-dup.1* ... Although it looks as though it doesn't pick up the deja-dup-preferences man page. For that, you need to add --all-name to the %find_lang call. > Not required anymore I didn't know that ! That is good. Should get updated in the review guidelines... upstream source: fine now BuildRequires: fine now %install: ok Please try to work out the %lang issue, but I don't think that needs to block the review. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
