Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=567348 --- Comment #2 from Ionuț Arțăriși <[email protected]> 2010-03-03 12:36:13 EST --- Thank you, Fabian (In reply to comment #1) > Just csome quick comments on your spec file: > > - Is 'CFLAGS="$RPM_OPT_FLAGS"' really needed? It's a noarch package. > - Please use '%global' instead of '%define' > > https://fedoraproject.org/wiki/Packaging:Guidelines#.25global_preferred_over_.25define Done. > - The README is missing in %doc I've not included the README because it contains installation instructions for Windows and Debian that I think are unneeded by fedora users. "Irrelevant documentation include build instructions, the omnipresent INSTALL file containing generic build instructions, for example, and documentation for non-Linux systems, e.g. README.MSDOS." https://fedoraproject.org/wiki/Packaging/Guidelines#Documentation > - The license is GPLv3+, source header says '3 of the License, or (at your > option) any later version.' I've updated it and added LGPLv2+ too after finding the build/lib/dreampielib/gui/SimpleGladeApp.py module. > - The latest release is 1.0.2 > > Please take a look at he following page, too : > https://fedoraproject.org/wiki/Packaging:Python I have. Could you please be a bit more specific as to what exactly you think is wrong? http://mapleoin.fedorapeople.org/pkgs/dreampie/dreampie.spec http://mapleoin.fedorapeople.org/pkgs/dreampie/dreampie-1.0.2-1.fc12.src.rpm %changelog * Wed Mar 3 2010 Ionuț C. Arțăriși <[email protected]> - 1.0.2-1 - fixed spelling error in description - don't make subp_main.py executable - don't pass cflags to build command - use global instead of define macros - changed license field to GPLv3+ and LGPLv2+ - updated to 1.0.2 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
