Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=576591 Terje Røsten <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #1 from Terje Røsten <[email protected]> 2010-03-24 17:52:32 EDT --- Okay, you has of course informed upstream IPTraf about the fork? Comments on the spec: %configure --enable-shared=no --enable-static=yes Why? Fedora tend to do the reverse. rm -rf Documentation/.xvpics If your are upstream maintainer this could be remove in the tarball? mkdir -p $RPM_BUILD_ROOT/etc/logrotate.d/ cp %{SOURCE1} $RPM_BUILD_ROOT/etc/logrotate.d/iptraf Change to install -D -m 0644 -p %{SOURCE1} $RPM_BUILD_ROOT/etc/logrotate.d/iptraf %attr(755,root,root) %{_prefix}/bin/* Remove %attr and, use bindir macro and list explicit. %{_mandir}/*/* Not so general please. %dir %attr(644,root,root) %config(noreplace) /etc/logrotate.d/iptraf Drop %attr, %dir seems wrong. - Initialization build I leave that to a native speaker. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
