https://bugzilla.redhat.com/show_bug.cgi?id=831871
--- Comment #3 from Alan Pevec <[email protected]> --- Yeah, then let's drop it, guidelines only mention that -doc subpackages should have Group: Documentation My other remarks from the review: - Source0: should be only filename when it's SCM snapshot http://fedoraproject.org/wiki/Packaging:SourceURL#Using_Revision_Control - Since it's a pre-release, Release: should be 0.1.%{snapshot_tag} http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Pre-Release_packages - In %files: %{python_sitelib}/*.egg-info would be easier for later updates Rest of it is ok: MUST OK rpmlint => rpmlint openstack-swift-plugin-swift3-1.0.0-20120612.1.fc16.* 2 packages and 0 specfiles checked; 0 errors, 0 warnings. OK name OK spec file name = %{name}.spec American English legible locales %find_lang UTF-8 filenames [-] Packaging Guidelines Needs small adjusments per above remarks. OK license Fedora approved spec field in %doc OK sources url => git archive --format=tar --prefix=swift3-1.0.0-5c74ba04/ 5c74ba04 | xz - > ../swift3-1.0.0-5c74ba04.tar.xz md5sum => echo "b21822c4fbfaa40f4164b371764abf76 swift3-1.0.0-5c74ba04.tar.xz" | md5sum -c swift3-1.0.0-5c74ba04.tar.xz: OK OK BuildRequires OK directories own all or require a package no directory conflicts OK no dups in %files (exception: license texts) OK Permissions OK consistently use macros OK code or permissable content SHOULD OK build in mock => http://koji.fedoraproject.org/koji/taskinfo?taskID=4161481 -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
