https://bugzilla.redhat.com/show_bug.cgi?id=828879

--- Comment #13 from Lukáš Czerner <[email protected]> ---
Hi Eric,

thank you very much for the review! I have updated description according your
comments in Comment 7.

Regarding the commands used in the system storage manager:

cryptsetup-luks - is not required and if not present crypt backend will not be
used. It has been designed this way.

device-mapper (dmsetup) - it is required only by crypt backend and again if it
is not present, it will not be used.

lvm2 - it is not required and if not present lvm backend will not be used. It
has been designed this way.

btrfs-progs - it is not required and if not present btrfs backend will not be
used. It has been designed this way.

util-linux - it already is required in the spec file

which - This have to be added into the required packages. Thanks for pointing
this out.

xfsprogs
e2fsprogs
   - Unfortunately I've completely forgot about those and the system storage
manager will not gracefully handle the situation when the file system tools are
missing. We are already working on a patch, however it might make more sense to
just require those two packages since it will probably cover most of the usual
setups anyway. I am going to add those packages to required for now.


Spec URL: http://people.redhat.com/lczerner/files/system-storage-manager.spec
SRPM URL:
http://people.redhat.com/lczerner/files/system-storage-manager-0.2-1.fc16.src.rpm


Thanks Eric!
-Lukas

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to