https://bugzilla.redhat.com/show_bug.cgi?id=825825

Mikolaj Izdebski <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |POST
              Flags|fedora-review?              |fedora-review+

--- Comment #8 from Mikolaj Izdebski <[email protected]> ---
> The latest upstream release is 2.3.4, but the packaged version is 1.3.10.
> Please explain why struts 1.x was packaged instead of 2.x.
> 
> springframework and velocity-tools requires the struts 1.x series.
> 
> for struts 2. there are unavailable build deps such as:
> org.springframework spring-aspects 3.0.5.RELEASE (depend on aspectjtools)

Ok, explaination good enough.

> Please explain in a comment why local Maven depmap is needed.
> 
> depmap forcing the use of tomcat 7.x apis

In a comment in the spec file I meant.

> Point 4 (d) of Apache License Version 2.0 requires shipping all NOTICE
> files along with all derrivate works. Struts includes several such
> NOTICE files, but only one of them is being installed. Please install
> all NOTICE files applicable to the package.
> 
> all NOTICE files contain the same content as the one already installed

True.

I am approving this package.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to