https://bugzilla.redhat.com/show_bug.cgi?id=749291

--- Comment #12 from Ricardo Rocha <[email protected]> ---
Hi.

Thanks for looking at this.

See inline.

(In reply to comment #10)
> Conform to the requester wish, I take care of this.
> 
> 
> First comments :
> 
> - build failure on f16/el/e6 ( I have not tested the other ) : 
>   ->http://koji.fedoraproject.org/koji/taskinfo?taskID=4187213
>   ->  http://koji.fedoraproject.org/koji/taskinfo?taskID=4187245

Forgot to say it, but for the moment it's aimed only at rawhide - that's where
xrootd >= 3.2 is available for now, which we depend on.

> -> BuildRequires 
> 
> - %{isa}  macro is not required on BuildRequires
> 
> - BuildRequires:      xrootd-libs is implicite in xrootd-devel
> 
> - GPL 3 -> No license file or no license in headers.
> 
> - shadowutil dependency -> not needed if no user/group modifications
> 
> - It is a good pratice to use %macro or $macro but not both for lisibility

All fixed. I've updated the spec to build the new upstream release 3.1.0.

http://rocha.web.cern.ch/rocha/fedora/dpm-xrootd.spec
http://rocha.web.cern.ch/rocha/fedora/dpm-xrootd-3.1.0-1.src.rpm

Koji build (rawhide):
http://koji.fedoraproject.org/koji/taskinfo?taskID=4196700

Thanks again,
  Ricardo

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to