https://bugzilla.redhat.com/show_bug.cgi?id=785442

--- Comment #5 from Remi Collet <[email protected]> ---
You could consider adding the implicit requires.
* Horde_Exception and Horde_Util (for Horde_String)
* php-common >= 5.2.0

You could also consider adding the "optional" dependency on Horde_Icalendar,
when it will be approved, if this don't create a circular dependency nightmare.

In Provides and %file, please use %{pear_name} where possible

A %{pear_channel} could be usefull (pear.horde.org)

Only blocker is (as you have drop other EL-5 stuff) 
MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to