https://bugzilla.redhat.com/show_bug.cgi?id=834481
Scott Tsai <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] Assignee|[email protected] |[email protected] Flags| |fedora-review? --- Comment #1 from Scott Tsai <[email protected]> --- (In reply to comment #0) Things I'd like changed in the .spec: 1. Package the latest upstream 2.0.3 release. http://lttng.org/files/lttng-tools/lttng-tools-2.0.3.tar.bz2 -Version: 2.0.2 +Version: 2.0.3 2. Use %{?dist} instead of %{dist} like most Fedora packages: -Release: 1%{dist} +Release: 1%{?dist} 3. Remove BuildRequires systemtap-sdt-devel since it's now been added to lttng-ust-devel -# This requires is missing from lttng-ust-devel, put it here for now -BuildRequires: systemtap-sdt-devel 4. -devel should use {?isa} when requiring the main package: -Requires: %{name} = %{version}-%{release} +Requires: %{name}%{?_isa} = %{version}-%{release} 5. Indent the %description for main and -devel to not have extra spaces at the front of the line: %description This package provides the unified interface to control both the LTTng kernel - and userspace (UST) tracers. +and userspace (UST) tracers. %description -n %{name}-devel - This package provides the development files to - implement trace control in external applications +This package provides the development files to +implement trace control in external applications 6. Don't ship /usr/lib64/liblttng-ctl.a Since /usr/bin/lttng-sessiond is dynamically linked and liblttng-ctl is used to control the former on the same machine, I don't think the static library was useful. -%configure --docdir=%{_docdir}/%{name} +%configure --docdir=%{_docdir}/%{name} --disable-static <...> %files -n %{name}-devel %{_prefix}/include/lttng/* %{_libdir}/*.so -%{_libdir}/*.a 7. Package the lttng bash completion script along with /usr/bin/lttng make DESTDIR=%{buildroot} install rm -vf %{buildroot}%{_libdir}/*.la install -D -m644 %{SOURCE1} %{buildroot}%{_unitdir}/lttng-sessiond.service +mkdir -p %{buildroot}%{_sysconfdir}/bash_completion.d +cp extras/lttng-bash_completion %{buildroot}%{_sysconfdir}/bash_completion.d/lttng <...> make DESTDIR=%{buildroot} install rm -vf %{buildroot}%{_libdir}/*.la install -D -m644 %{SOURCE1} %{buildroot}%{_unitdir}/lttng-sessiond.service +mkdir -p %{buildroot}%{_sysconfdir}/bash_completion.d +cp extras/lttng-bash_completion %{buildroot}%{_sysconfdir}/bash_completion.d/lttng I've uploaded a copy of the .spec with my recommended changes above here: http://scottt.tw/fedora/lttng-tools.spec -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
