https://bugzilla.redhat.com/show_bug.cgi?id=837313

Toshio Ernie Kuratomi <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]
              Flags|fedora-cvs?                 |fedora-cvs-

--- Comment #3 from Toshio Ernie Kuratomi <[email protected]> ---
Andreas -- Could you go back and please do a proper Fedora Review?  Just
looking at the spec file and not attempting to build or understand gssproxy at
all, I immediately see two things wrong with it (Not a complete URL to the
Source, scriptlets for installing systemd units are wrong).  The lack of any
Requires: is also fishy to me... I'm thinking there's probably at least a
missing Requires: on some systemd package.  The ldconfig invocation in the
%post script is also fishy -- I don't see any libraries being installed and if
there were libraries installed, there's no matching ldconfig call in %postun. 
If you dig into the package you may find even more stuff wrong.

For help with doing a proper review, you can look at:
http://fedoraproject.org/wiki/Packaging:ReviewGuidelines

and 

http://fedoraproject.org/wiki/Packaging:Guidelines

The scriptlets for systemd are on:

http://fedoraproject.org/wiki/Packaging:Systemd

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to