https://bugzilla.redhat.com/show_bug.cgi?id=832816

--- Comment #3 from gil cattaneo <[email protected]> ---

what's means imho?

> a) The not existence of src and demo package is  inttional? (means *1) - imho 
> it is more then worthy
yes
b) contrib directory is not worthy to be packed?
no unavailable deps package org.jboss.system
c) test can not be run during build?

> d) /./usr/share/java/MckoiSQLDB.jar is symlink to mckoi.jar. In that case I 
> would recommand full version in mockoi-{version}.{release}.jar filename
not
can not do. see https://fedoraproject.org/wiki/Packaging:Java#Filenames

> e) in javadoc package ther is "bug" I do not understand -  
> /./usr/share/javadoc/mckoi/ contains javadoc and 
> /./usr/share/doc/mckoi-javadoc-1.0.4/ contains licence. (also 
> /./usr/share/doc/mckoi-1.0.4/ contains licence and readme for main package)
   imho /./usr/share/javadoc/mckoi/ should be symlink to
/./usr/share/javadoc/mckoi-1.x.y/ which will then contains real javbadoc
see
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Subpackage_Licensing
and
https://fedoraproject.org/wiki/Packaging:Java#Javadoc_installation

> f) there is directory doc in BUILD. It contains interesting information. IMHO 
> they shoud go out in /./usr/share/doc/mckoi-1.0.4/ too (or whereevere you 
> decide)
yes if only mckoi is packaged as as db

> g) Isnt worthy some kinf of shell launcher to jar so anybody can connect 
> easily to db? (but here I have lack of mckoi db knowledge)
mckoi is packaged as library and not as db, for now i haven't interest to add a
launcher script

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to