https://bugzilla.redhat.com/show_bug.cgi?id=831878
Keith Robertson <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(tomspur@fedorapro | |ject.org) --- Comment #5 from Keith Robertson <[email protected]> --- First, thanks for the review! Here are my responses: Problem 1: >[!]: MUST Buildroot is not present >See https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag I'm not sure what it is complaining about here. I use %{buildroot} in the .spec. Further, the wiki says... "Fedora (as of F-10) does not require the presence of the BuildRoot tag in the spec...". Problem 2: >[!]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the > beginning of %install. >See https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag Huh? The spec file does exactly this that. Here are the relevant lines from my spec: %install rm -rf %{buildroot}/* <--- See. make PREFIX=%{buildroot}/ install Problem 3: >[!]: MUST Rpmlint output is silent. > ovirt-log-collector.src: W: non-standard-group Virtualization/Management Fixed. Set to "Applications/System". > ovirt-log-collector.src: W: invalid-url Source0: http://ovirt.org/releasesI Fixed. Problem 4: > rpmlint ovirt-log-collector-3.1.0-0.fc18.noarch.rpm > ovirt-log-collector.noarch: W: non-standard-group Virtualization/Management Fixed. > ovirt-log-collector.noarch: W: incoherent-version-in-changelog 1.0.0-0 > ['3.1.0-0.fc18', '3.1.0-0'] Fixed. Problem 5: >> ovirt-log-collector.noarch: W: manual-page-warning >> /usr/share/man/man8/engine-log-collector.8.gz 28: name expected (got a >> special character): treated as missing > Not sure what this means, but it's a warning anyway. Yeah, I have no idea how to fix this. Problem 6: > It would be best to include this as engine-log-collector.8.* I tried this and rpmlint complained with the following: "ovirt-log-collector.noarch: W: manual-page-warning /usr/share/man/man8/engine-log-collector.8.gz 28: name expected (got a special character): treated as missing" Problem 7: >> ovirt-log-collector.noarch: E: non-readable >> /etc/ovirt-engine/logcollector.conf 0600L >Could you change it to 0644 ? Actually, 0600 is the right permission set. The user *could* choose optionally to set the password for the oVirt RESTful API in there. Problem 8: > Either unset executable bits or add shebang. Fixed. Unset exec bits. Problem 9: > I can't say the %doc macro is wrong here, but I've never seen it together with %{_mandir} so I'd remove it Removed. Problem 10: > You can put it on one line like: '%doc AUTHORS LICENSE' Done -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
