https://bugzilla.redhat.com/show_bug.cgi?id=841089

Vít Ondruch <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+

--- Comment #2 from Vít Ondruch <[email protected]> ---
* Name of test suite archive
  - Although this is a minor nit, I would appreciate if you could adjust the
    Source1 name to %{gem_name}-%{version}-tests.tgz at least. That would be
    more aligned with the packaging guidelines example [1] and other Rails
    packages that already uses this approach.

Please consider fixing this minor nit. Otherwise, the package looks good =>
APPROVED



[1]
https://fedoraproject.org/wiki/Packaging:Ruby#Test_suites_not_included_in_the_package

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to