https://bugzilla.redhat.com/show_bug.cgi?id=841003

--- Comment #24 from Rex Dieter <[email protected]> ---
OK, now that the %files list is clearer,

4. MUST omit static libraries and libtool archives, ie, items that match
%{_libdir}/lib*.a
%{_libdir}/lib*.la
(or provide justification why they warrant an exception)

5. SHOULD own includedir subdirectories.  One easy way to do that, is to just
include:
%{_includedir}/matecorba-2.0/
which will include it, and recursively everything under it

6. SHOULD.  this
%{_bindir}/matecorba-linc-cleanup-sockets
looks like something that ought to be in the main runtime pkg instead of -devel

7. -devel MUST have an arch'd dependency on the main pkg, use this instead:
Requires: %{name}%{?_isa} = %{version}-%{release}

8.  MUST drop
Requires: mate-common
this is a BuildRequires only, not required for normal runtime use.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to