https://bugzilla.redhat.com/show_bug.cgi?id=822959
Brenton Leanhardt <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #3 from Brenton Leanhardt <[email protected]> --- Other things that need to be fixed: When I tried to build with mock the 'intltool' BuildRequire was missing. It's also preferable to require 'python-devel'. That will BuildRequire python as well as give you access to convenient macros like %{__python} https://fedoraproject.org/wiki/Packaging:Python#BuildRequires You need to install nitrotasks.desktop.in as mentioned here: http://fedoraproject.org/wiki/Packaging/Guidelines#Desktop_files You need to verify that permission has been granted to distribute logos for DropBox, Ubuntu. There is also an image of Justin Bieber that is probably not free to distribute. http://fedoraproject.org/wiki/Packaging/Guidelines#Tags The Vendor tag should not be used. It is set automatically by the build system It's adviseable to work with upstream to clearly state the copyright holder in the COPYING file. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
