https://bugzilla.redhat.com/show_bug.cgi?id=844090
Jonathan Dieter <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+ --- Comment #7 from Jonathan Dieter <[email protected]> --- The first three issues can be ignored if you're planning to package this for EPEL-5. If not, they should probably be fixed. The fourth issue is a that you could have a proper source url rather than the source plus comment. I'm not sure if you had a reason for doing it the way you did? Finally, you could argue that the patches should have comments explaining their necessity and why they're not upstream, but I think the patch names do a good enough job of explaining that. I'm going to mark this approved, so, after at least the fourth issue is fixed (unless there's a reason for why you didn't do the source url), go ahead and do the CVS request. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
