https://bugzilla.redhat.com/show_bug.cgi?id=839395
--- Comment #7 from Michael Scherer <[email protected]> --- Is this package intended to go to EPEL 5 ? If not, there is a serie of item to clean ( %defattr, %clean, rm -Rf %buildroot in %install, BuildRoot tag ). Fedora review also complain about : - [!]: MUST Gem package must exclude cached Gem. See: http://fedoraproject.org/wiki/Packaging:Ruby but I do not see where this is written. I think that's this : %{gem_dir}/cache/%{gem_name}-%{version}.gem and indeed, if the code is already shipped outside of the gem, no need to bundle it a 2nd time. - Regarding the various requirement : rubygem(highline) rubygem(json_pure) rubygem(parseconfig) are not needed, since they do not seems to be used in the code. - I think rubygem(rails) is needed, since common do not requires it, and the controller code use it. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
