https://bugzilla.redhat.com/show_bug.cgi?id=845342
Bohuslav "Slavek" Kabrda <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #2 from Bohuslav "Slavek" Kabrda <[email protected]> --- There are two things that I found wrong on this package: - Wrong provides/obsoletes. According to [1], they should look like this: Provides: rubygem(hmac) = %{version}-%{release} Obsoletes: rubygem(hmac) < 0.4.0-6 - The specfile still has name rubygem-hmac.spec, although it should now be rubygem-ruby-hmac.spec. Otherwise the package looks good, so it is APPROVED, but please fix the above before comitting to dist-git. [1] http://fedoraproject.org/wiki/Packaging:Guidelines#Renaming.2FReplacing_Existing_Packages -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
