https://bugzilla.redhat.com/show_bug.cgi?id=845628
Mario Blättermann <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |[email protected] | |m Assignee|[email protected] |[email protected] | |m Alias| |mate-mime-data --- Comment #4 from Mario Blättermann <[email protected]> --- It is not needed to submit your patches to your review request, because they are already included in your srpm. Some initial comments: Please drop %defattr from the file list. It is not needed unless you want to provide your package for EPEL <6 (which I don't assume). %config has to be %config(noreplace). When you add this suffix, this config file won't be replaced when the package will be updated, if someone has changed it in the meantime. Drop NEWS from the docs, because it is empty. The *.pc file has to be in a -devel subpackage. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
