https://bugzilla.redhat.com/show_bug.cgi?id=752169

--- Comment #61 from Tim Lauridsen <[email protected]> ---
Look fine to me.
A more cosmetic issue is having multiple requirement i a single line, it makes
it hard to read, I would prefer that you add one require line for each
requirement.

Ex.

Requires:       %{name}-common = %{version}-%{release}, gtk-murrine-engine >=
0.98.1.1 gtk2-engines

should be.

Requires:       %{name}-common = %{version}-%{release}
Requires:       gtk-murrine-engine >= 0.98.1.1
Requires:       gtk2-engines

It also make git diff easier to read when doing updates to requirement

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to