https://bugzilla.redhat.com/show_bug.cgi?id=846562

--- Comment #4 from Marcela Mašláňová <[email protected]> ---
I used Fedora-Review for review, which check everything. Let's start with the
biggest issues.

License: the directory 3rdparty contains code under various licenses. There is
also sha1.c file, which might be better use from system library. The license
can't be Artistic 2.0 if some parts of code are under different license.

-devel sub-package is missing.

If you want to push this package into EPEL-5 you will need more changes in the
specfile.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to