Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=571225 Sandro Mathys <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs? --- Comment #3 from Sandro Mathys <[email protected]> 2010-04-07 03:47:57 EDT --- Thanks for the review! (In reply to comment #2) > Issues to point out: > - It's better to list the manpage as '%{_mandir}/man1/petit.1.*' to prevent > problems in case the compress algorithm changes. Well, this is not blocking > the review but I'd like to see it fixed before you request CVS access. Done (locally). > - I could not find out if there is any newer upstream version of petit than > 1.0.0, > the website doesn't provide information about that or I completely missed > it. 1.0.0 is the latest release, see: http://opensource.eyemg.com/files/petit/ But you're right, the website itself does not tell what's the newest version. Asked upstream to change that. > - Removing the .svn dirs should be upstreams job, right before putting > sources > into a tarball. You might want to contact upstream to suggest 'svn export' > before releasing. :) Suggested. > Your package looks good anyway and is APPROVED. Thanks again! New Package CVS Request ======================= Package Name: petit Short Description: Log analysis tool for syslog, Apache and raw log files Owners: red Branches: F-12 F-13 EL-5 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
