https://bugzilla.redhat.com/show_bug.cgi?id=847436
Jaroslav Reznik <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #2 from Jaroslav Reznik <[email protected]> --- Name: ok Release: ok Summary: ok Group: not needed anymore, optional tag, http://fedoraproject.org/wiki/Packaging:Guidelines#Group_tag License: ok, CC-BY-SA URL: not yet created, standard destination for Fedora artwork, please create asap Sources: ok, md5sum d62c522b46ddf16fe191d8060da449eb BuildArch: ok BuildRequires: ok Requires: ok Descriptions: ok Macros used consistently: ok %clean section is not needed anymore, http://fedoraproject.org/wiki/Packaging:Guidelines#.25clean rm -rf $RPM_BUILD_ROOT is not needed anymore in %install section, http://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag Otherwise it's a simple package, based on beefy-miracle-backgrounds package. You can cleanup the SPEC file according to the current package guidelines but it's not a blocker and the package has to be finalized today. APPROVED -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
