Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=549223

Martin Gieseking <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]

--- Comment #1 from Martin Gieseking <[email protected]> 2010-04-07 
14:38:48 EDT ---
Hi Fabian,
here are a couple of initial comments:

- GConf schemas files must be handled properly, see:
  http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#GConf

- According to COPYING.extras, the PNG images are licensed under GPLv2.
  This must me reflected in the License field
  Since GPLv2 is not compatible with GPLv3+, I'm not sure if upstream is
allowed 
  to license the whole package under GPLv3+

- in the %files section, replace omf/ignuit with omf/%{name}

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to