https://bugzilla.redhat.com/show_bug.cgi?id=844013
--- Comment #12 from Michael Scherer <[email protected]> --- Why those permissions : %attr(0664,-,-) %ghost /usr/share/selinux/packages/%{name}/stickshift-broker.pp I would use 644 rather, no ? For booleans, that's not a blocker, but I fear that's something that could annoy people if they write custom policy. Admin tend to not like this :) But I guess that once someone review the selinux policy, this will be taken care of. And moving config to /etc is not a blocker, but better have it done before the first stable packages to avoid migration later. Maybe this is too late, since there is already a repository. For apache, i fear you removed too much. IE, while most of the file should not be owned by apache, I can see reason for directory where the name implies that something will be written there : %{brokerdir}/log %{brokerdir}/run %{brokerdir}/tmp I will finish the review tomorow, too late now for this. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
