https://bugzilla.redhat.com/show_bug.cgi?id=839395
--- Comment #15 from Vít Ondruch <[email protected]> --- * ruby-devel - You probably don't need this dependency, since this is pure Ruby gem. * Patching after gem build - I am not sure I understand the purpose of this patch, or better why to patch after you build the gem? * Use gem packaging macros - In %install section, please replace %{gem_dir}/gems/%{gem_name}-%{version}/lib => %{gem_libdir} %{gem_dir}/gems/%{gem_name}-%{version} => %{gem_instdir} * Do not %exclude %{gem_libdir} * Mark only documentation as a %doc - i.e. Gemfile, Rakefile, %{gem_name}.gemspec should not be marked as a %doc * Please consider splitting documentation into -doc subpackage. - BTW are you aware of gem2rpm tool? This would create the -doc subpackage for you and much more. * Please consider execution of test suite * Please keep the documentation in the package - There is no reason to remove the test suite IMO. - In case you created the -doc subpackage, the test suite should be moved there. * CONFIGURE_ARGS is not needed - This is needed just for binary gems. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
