https://bugzilla.redhat.com/show_bug.cgi?id=850679
--- Comment #5 from Bohuslav "Slavek" Kabrda <[email protected]> --- (In reply to comment #4) > > Please run the upstream specs in %check section. > Which one? I see non in that gem file. > Yes, upstream sometimes doesn't include test suite in the .gem file, but has them [1]. There is a quick howto for such cases in Ruby packaging guidelines [2]. I consider this a blocker, running tests/specs is very important. > > make the scripts in examples executable > This is not intended for runnning (will even SELinux allow it?) and it is in > gem_docdir. I assume the intention is that developer will just read it as > sample tutotiral. Do you see this as blocker? > Not a blocker, but your current way is not consistent. Either make _all_ of the examples executable or _all_ non-executable. I'd still prefer making them executable, as I don't see any possible selinux problems there. [1] https://github.com/yob/pdf-reader/tree/master/spec [2] https://fedoraproject.org/wiki/Packaging:Ruby#Test_suites_not_included_in_the_package -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
