https://bugzilla.redhat.com/show_bug.cgi?id=847604

--- Comment #5 from Rex Dieter <[email protected]> ---
OK, initial review comments.

1.  SHOULD  move
NOCONFIGURE=1 ./autogen.sh
to %prep section

2.  SHOULD drop  -libs subpkg, this one's name already starts with  lib*,  and
I see little risk for  multilib conflicts.  (while you're at it, seems  to 
have  2 %files sections, remove the dup)

3.  MUST:  like item 2 from comment #2, MUST add mateconf-related scriptlets
for
desktop_mate_peripherals_keyboard_xkb.schemas

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to