https://bugzilla.redhat.com/show_bug.cgi?id=852329

Alan Pevec <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]

--- Comment #1 from Alan Pevec <[email protected]> ---
Preliminary quick review:

* rpmlint vdsm-hooks.spec 
vdsm-hooks.spec: W: invalid-url Source0: vdsm-4.9.6.tar.gz

It's quite unsual to have 2 SRPM from one upstream tarball, but at least
provide full URL or comments how the tarball is generated:
http://fedoraproject.org/wiki/Packaging:SourceURL

* all vdsm-hook-* need to depend on vdsm, since they're under
%{_libexecdir}/vdsm/
 
http://fedoraproject.org/wiki/Packaging:Guidelines#File_and_Directory_Ownership

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to