https://bugzilla.redhat.com/show_bug.cgi?id=853378
--- Comment #3 from Simone Caronni <[email protected]> --- Woah. So many errors. Thanks for your review. I didn't know about cpanspec, I regenerated the spec file with it and added the changes regarding the errors you pointed out. I left the EPEL 5 stuff in and I will ask the perl-Log-Dispatch mantainer if the latest Log::Dispatch can also be built for EPEL 5. It if it's not, I will not push anything to the el5 branch. $ rpmlint perl-Log-Dispatch-Configurator-Any.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. These are the things I've not fixed yet: * Missing BuildRequires: perl(base) Is this really needed? cpanspec does not add it and is pulled in by other modules. * Optional BuildRequires for tests: perl(Test::Pod) >= 1.14 and perl(Test::Pod::Coverage) >= 1.04 Should I add those? They are both in EPEL but cpanspec does not have added them. Spec URL: http://slaanesh.fedorapeople.org/perl-Log-Dispatch-Configurator-Any.spec SRPM URL: http://slaanesh.fedorapeople.org/perl-Log-Dispatch-Configurator-Any-1.110690-2.fc17.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
