https://bugzilla.redhat.com/show_bug.cgi?id=853553
Terje Røsten <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #2 from Terje Røsten <[email protected]> --- Some comments: o choose %{buildroot} or $RPM_BUILD_ROOT, use only one variant o change %{_datadir}/guayadeque/* to %{_datadir}/guayadeque o why is _pkgbuilddir needed? If needed: use %global o change svn1830.1%{?dist} to 1.svn1830%{?dist} : http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Non-Numeric_Version_in_Release o some source files are under GPLv2+, however MD5.cpp and hmac/* are not and maybe more. Please have a closer look. Could you do a koji scratch build? -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
