Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=580744 Martin Gieseking <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #1 from Martin Gieseking <[email protected]> 2010-04-09 08:36:25 EDT --- Hi Damien, here are a couple of initial comments: - the above SPEC and SRPM are out of sync (spec files differ) - change %{?disttag} to %{?dist} in the Release field - The tarball contains a copy of gettext. You should remove it and use the correspondent Fedora package instead. Some additional patching might be necessary. - The tarball contains several tests. It's probably a good idea to run them (in a %check section). - The changelog seems to be incomplete. Some releases are not listed, e.g. 0.25.9-1, -2, -3. - The header format of the changelog entries should be consistent. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
