https://bugzilla.redhat.com/show_bug.cgi?id=855283

--- Comment #12 from Jason A. Donenfeld <[email protected]> ---
(In reply to comment #6)
> Looking at the source code, there is a call to qdus, but qt is not in
> Requires.

However, qdbus should absolutely NOT be required. It's run with >/dev/null
2>&1, and in the future there are going to be other similar lines there --
gdbus org.gnome.somethingawful.clipthing ClearIt -- and the like. The idea is
-- if the user has that environment, and has those services, then it will work,
and otherwise this is a no-op. This is usually the cleanest thing to do in a
simple shell script.


> There is also a call to pwgen, and not in Requires either.

Pwgen should absolutely be required.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to