https://bugzilla.redhat.com/show_bug.cgi?id=854764
--- Comment #3 from Michael Scherer <[email protected]> --- What do you mean in a "nobase environnement" ? As far as i know, we consider that that least group core would be installed, so IMHO : coreutils initscripts util-linux-ng and iproute are counted as being installed on Fedora. However, you are right for sed, as it doesn't seem to be there in minimal install. Regarding old EL5 stuff, there is : rm -rf $RPM_BUILD_ROOT in %install too. And as i may not have been clear, the part : %files %if %{with_systemd} %attr(0644,-,-) %{_unitdir}/stickshift-proxy.service %attr(0644,-,-) %{_sysconfdir}/sysconfig/stickshift-proxy %else %attr(0750,-,-) %{_initddir}/stickshift-proxy %endif %attr(0755,-,-) %{_bindir}/stickshift-proxy-cfg %dir %attr(0750,root,root) %{_localstatedir}/lib/stickshift/.stickshift-proxy.d %attr(0640,-,-) %config(noreplace) %{_sysconfdir}/stickshift/stickshift-proxy.cfg would be cleaner as %files %if %{with_systemd} %{_unitdir}/stickshift-proxy.service %{_sysconfdir}/sysconfig/stickshift-proxy %else %{_initddir}/stickshift-proxy %endif %{_bindir}/stickshift-proxy-cfg %dir %attr(0750,-,-) %{_localstatedir}/lib/stickshift/.stickshift-proxy.d %config(noreplace) %{_sysconfdir}/stickshift/stickshift-proxy.cfg Since permissions are already set in the spec by install a few line before. I do not understand when the config from /etc/ is copied to /var to be used by the service, can you clarify that, and decide which one should be dropped ( because having 2 configuration when only one is used doesn't make sense ) ? -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
