https://bugzilla.redhat.com/show_bug.cgi?id=856217

Matthias Runge <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |[email protected]
           Assignee|[email protected]    |[email protected]
              Flags|                            |fedora-review?

--- Comment #2 from Matthias Runge <[email protected]> ---
Some drive-by comments:
- no need to define BuildRoot: anymore
- you don't need to clean the buildroot during install anymore
- even the clean: section is not required anymore
- no need to defattr in %files section, only, when building for epel5

Those four are deprecated and shouldn't be used any more.

- project homepage is currently: http://sourceforge.net/projects/quearcode/
(unless you'll configure projects sf-page else ;-) )
quearcode.src: W: invalid-url URL: http://quearcode.sourceforge.net HTTP Error
403: Forbidden


Full review to follow.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to