https://bugzilla.redhat.com/show_bug.cgi?id=854679
Jan Synacek <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?([email protected] | |om) --- Comment #2 from Jan Synacek <[email protected]> --- Specfile: - use %global instead of %define - do not use BuildRoot: - do not use rm -rf %{buildroot} in install section (unless you intend to use the package for EPEL) - do not use %defattr (unless you intend to use the package for EPEL) - also, I believe there is a typo on line 36: + rm -f {buildroot}... should probably be rm -f %{buildroot}... Also, rpmlint complains a lot about incorrect fsf addresses: python-sudsds.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/sudsds/transport/https.py python-sudsds.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/sudsds/bindings/__init__.py python-sudsds.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/sudsds/mx/typer.py That should probably be reported and corrected by upstream. Other than that, I don't see any more things that need correction. The package also does not conflict with 'python-suds' that is already present in Fedora. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
