https://bugzilla.redhat.com/show_bug.cgi?id=785462

Volker Fröhlich <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]

--- Comment #6 from Volker Fröhlich <[email protected]> ---
Remove the two "Requires". rpmbuild figures that out.

There's no need to define that pkgname macro. Just use the name macro instead.

%setup -q is enough, as name-version is the default name.

Don't mix tabs and spaces in the spec file.

Delete the .la files, if you can't avoid creating them.

Having a more precise file section wouldn't hurt. Use the name macro in the
files section too.

%{_libdir}/sinfo/* -- This is wrong because it'd leave the directory without an
owner. Make that %{_libdir}/sinfo.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to