https://bugzilla.redhat.com/show_bug.cgi?id=851891

Mario Blättermann <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]
                   |                            |m

--- Comment #4 from Mario Blättermann <[email protected]> ---
Would be nice to have a direct download link for the spec, as follows:
http://git.dyroff.org/?p=sdyroff-rpms.git;a=blob_plain;f=SPECS/wiki2beamer.spec;h=103ec5270dfc19bfee8f47b345796fe2fbd628fd;hb=72206497496f45f965646753b8e6fdbdae57e1da

Some initial comments:

A "Release: 0" doesn't exist. Use "Release: 1%{?dist}" for your first release
of a certain upstream version and bump it each time you change anything.

The initial cleaning of buildroot in %install and the %clean section are
obsolete, unless you want to provide your package for EPEL5.

Perhaps you should rename fdl.txt to LICENSE-DOCS or anything similar to make
it somewhat clearer what this file refers to. However, it is not forced by the
packaging guidelines, just an idea.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to