https://bugzilla.redhat.com/show_bug.cgi?id=859671
Volker Fröhlich <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #2 from Volker Fröhlich <[email protected]> --- BR gpsd and tinyxml. The license is not GPLv2, but GPLv2+ at least. Run the licensecheck program on the files. It will also help you in the following: The project seems to borrow code from various libraries. Among them: - wxjson - gdal - jeeps (That one's OK, as far as I remember. Upstream is dead for ages.) I believe parts of grib and nmea are included as well. Please delete this code in the prep section and make the software use the system-wide libraries instead. Also delete the tinyxml code. rpm-build should not be listed as a BR. It's not necessary to do so. Requires: gcc-c++ is likely unnecessary as well, but I haven't tested it. Please drop the license part from the description. I consider that redundant. rm -rf $RPM_BUILD_ROOT in the install is obsolete. You can use "%{_defaultdocdir}" instead of "%{_datadir}/doc/". Use the version macro in Source0 and %setup, as well as in your sed invocations. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
