https://bugzilla.redhat.com/show_bug.cgi?id=856114
--- Comment #2 from Rex Dieter <[email protected]> --- naming: NOT ok, since this package is to replace qxmpp, per http://fedoraproject.org/wiki/Packaging/Guidelines#Renaming.2FReplacing_Existing_Packages 1. Must add (something like) Obsoletes: qxmpp-dev < 0.7.3 Provides: qxmpp-dev = %{version}-%{release} and to -devel subpkg, Obsoletes: qxmpp-dev-devel < 0.7.3 Provides: qxmpp-dev-devel = %{version}-%{release} sources: ok 5badeba0db3d87e4d56ac8ac6da71fda qxmpp-0.7.3.tar.gz 2. SHOULD drop not needed or used Group: tags scriptlets: ok macros: ok 3. SHOULD create/use upstreamable patch instead of this .spec hack: %if "%{_lib}" == "lib64" %__mv ${RPM_BUILD_ROOT}/usr/{lib,lib64} %endif 4. MUST move these from -devel to main pkg: %doc AUTHORS CHANGELOG LICENSE.LGPL README -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
