https://bugzilla.redhat.com/show_bug.cgi?id=860542

--- Comment #2 from Rex Dieter <[email protected]> ---
$ rpmlint kchildlock.spec 
0 packages and 1 specfiles checked; 0 errors, 0 warnings

naming: ok

sources: ok, but
1. SHOULD adjust url to match recommendations for sf:
https://fedoraproject.org/wiki/Packaging:SourceURL#Sourceforge.net

2. SHOULD use
BuildRequires: kdelibs4-devel
(instead of kdelibs-devel)

3. SHOULD drop use of deprecated/unused rpm .spec tags, including:
Group:

4. MUST own
%{_localstatedir}/opt/%{name}

5. MUST add icon scriptlets:
https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache

6. SHOULD use
%{_kde4_datadir}/kde4/services/*
instead of
%{_datadir}/kde4/services/*
(ie, consistently use %{_kde4_*} style macros

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to