https://bugzilla.redhat.com/show_bug.cgi?id=862160
--- Comment #13 from Sebastian Dyroff <[email protected]> --- You are intending to package this for EPEL5 right? If so, some issues are irrelevant. There is a COPYING file which contains the license. It should be listed via %doc. The INSTALL file does not look like relevant documentation, it can be removed. I think, the license is GPLv2+. fedora-review produces the following issues: Issues: [!]: MUST Each %files section contains %defattr if rpm < 4.4 Note: defattr(....) present in %files section. This is OK if packaging for EPEL5. Otherwise not needed See: http://fedoraproject.org/wiki/Packaging/Guidelines#FilePermissions [!]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf is only needed if supporting EPEL5 See: None [!]: MUST If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text [!]: MUST License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. No licenses found. Please check the source files for licenses manually. See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#ValidLicenseShortNames There are some SHOULD issues too: [!]: SHOULD Buildroot is not present Note: Invalid buildroot found: %{_tmppath}/%{valkyrie}-%{release}-root-%(%{__id_u} -n) [!]: SHOULD Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: Clean is needed only if supporting EPEL5 [!]: SHOULD Spec use %global instead of %define. Note: %define valkyrie %{name}-%{version} -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
