https://bugzilla.redhat.com/show_bug.cgi?id=859994

--- Comment #3 from Vít Ondruch <[email protected]> ---
(In reply to comment #1)
> * .yard-doc
>   - There is no such folder in the gem. Please drop the .yard-doc line from
> the
>     %files section, since the package builds just fine without it in mock or
>     koji.

This item still applies. This exclude line should be removed.

* Macro forms of system executables SHOULD NOT be used [1]
  - Please use plain "rm" instead of %{__rm}

* Changelog
  - Although we are just in review process, it is good to update the
    %changelog entries appropriately, e.g. you should keep the 2.0.2-1 entry
    and add new 2.0.3-1 with description of changes.
  - For now, keep it as it is, but please remember for the future.


Otherwise, the package looks good and it can be approved, as soon as you get
sponsored.

[1] https://fedoraproject.org/wiki/Packaging:Guidelines#Macros

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to