https://bugzilla.redhat.com/show_bug.cgi?id=865240

Parag AN(पराग) <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |[email protected]
           Assignee|[email protected]    |[email protected]
              Flags|                            |fedora-review+

--- Comment #1 from Parag AN(पराग) <[email protected]> ---
Review:

+ Koji scratch build for f19 is ->
http://koji.fedoraproject.org/koji/taskinfo?taskID=4580598

+ rpmlint on rpms gave
liborcus-devel.x86_64: W: no-documentation
liborcus-tools.x86_64: W: no-documentation
liborcus-tools.x86_64: W: no-manual-page-for-binary orcus-format-xml
4 packages and 0 specfiles checked; 0 errors, 3 warnings.

+ Source verified with upstream as (sha256sum)
e37c72d1cdb9f5aab2b8b075c5dcc5b7ece2fd2646d93a1c6128d13bedc91754 
liborcus_0.1.0.tar.bz2
e37c72d1cdb9f5aab2b8b075c5dcc5b7ece2fd2646d93a1c6128d13bedc91754 
../SOURCES/liborcus_0.1.0.tar.bz2

+ Follows packaging guidelines

Suggestions:
1) Good to preserve timestamps of installed files from source as
make install DESTDIR=%{buildroot} INSTALL="install -p"

APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to