https://bugzilla.redhat.com/show_bug.cgi?id=772521

--- Comment #8 from Elder Marco <[email protected]> ---
Just a few comments. If you don't have plans to maintain this package for EPEL,
you can remove

* the BuildRoot tag;
* the %clean section;
% the %defattr section. This section is no longer necessary.

The Group tag is optional and you can remove it, if you want.

See the packaging guidelines:
https://fedoraproject.org/wiki/Packaging:Guidelines#Tags
https://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions


I think you don't need to add glibc as BuildRequires:
https://fedoraproject.org/wiki/Packaging:Guidelines#Exceptions_2

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to